[libcxx-commits] [PATCH] D122536: [libc++] Optimize `exception_ptr`, especially for the empty case

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 6 10:46:51 PDT 2022


philnik added a comment.

In D122536#3633355 <https://reviews.llvm.org/D122536#3633355>, @fwolff wrote:

> In D122536#3631434 <https://reviews.llvm.org/D122536#3631434>, @fwolff wrote:
>
>> I think the main problem were the inconsistent abilist files, which I have attempted to fix here
>
> This problem does indeed appear to be fixed now, judging by the latest CI run. But there are now some problems on Mac OS, which I cannot reproduce because I don't have such a machine. Perhaps someone else can have a look at this?

The problem is that you have introduced new symbols to the dylib. I think the easiest way to avoid this is to use `__cxa_{increment, decrement}_exception_refcount` in the header directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122536/new/

https://reviews.llvm.org/D122536



More information about the libcxx-commits mailing list