[libcxx-commits] [PATCH] D129007: [libc++][format] Implements 128-bit support.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jul 6 09:25:48 PDT 2022


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.signed_integral.pass.cpp:92
   }
-
-  // TODO FMT Implement the __int128_t minimum and maximum once the formatter
-  // can handle these values.
+#ifndef _LIBCPP_HAS_NO_INT128
+  if (sizeof(A) > 8) {
----------------
This applies elsewhere in this patch too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129007/new/

https://reviews.llvm.org/D129007



More information about the libcxx-commits mailing list