[libcxx-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D127444#3609719 <https://reviews.llvm.org/D127444#3609719>, @EricWF wrote:

> Ah, I see we limit ourselves to valid identifiers. LGTM again, just with a knob to turn it off.

I'm against this on principle, but I'll do it to unblock this patch. IMO this is the wrong way to reduce the size of object files -- we should be using compression mangling instead, and it's not a super idea to change our overall ABI stability promise just for that reason. But as I said, I'll add an escape hatch with a comment about using compression mangling instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127444/new/

https://reviews.llvm.org/D127444