[libcxx-commits] [PATCH] D129056: [libc++] Prefer __has_builtin for detecting compiler-provided type_traits

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general looks good, but I really like to see it pass all CIs. (I know the current failures aren't due to this patch.)



================
Comment at: libcxx/include/__type_traits/is_convertible.h:32
 
-#else  // __has_feature(is_convertible_to)
+#else  // __has_builtin(__is_convertible_to)
 
----------------
please update the comment to match the `#if`, same for the `#endif`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129056/new/

https://reviews.llvm.org/D129056