[libcxx-commits] [PATCH] D128021: [libc++] Don't call key_eq in unordered_map/set rehashing routine

[Ivan via Phabricator via libcxx-commits]

itrofimow added a comment.

In D128021#3627048 <https://reviews.llvm.org/D128021#3627048>, @Mordante wrote:

> In D128021#3627047 <https://reviews.llvm.org/D128021#3627047>, @itrofimow wrote:
>
>> binary size after changes: https://pastebin.com/raw/z23mLN93
>
>
>
>    text	   data	    bss	    dec	    hex	filename
>   10323	    744	      8	  11075	   2b43	binary_size_main
>   10996	    744	      8	  11748	   2de4	binary_size_patch
>
> Thanks! I like these numbers better! This about half of the size overhead of the previous version.
> I assume the main values have changed due to rebasing, right?

I did rebase, however i think main values changed due to me compiling on a different machine.
Not sure if i understand the `size` command output completely, but this time binary takes only ~150 bytes more on disk versus ~4.5Kb in the previous version

Smh about losing context - updated the patch via web interface, will fix remaining issues and upload the patch via arc this time


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128021/new/

https://reviews.llvm.org/D128021