[libcxx-commits] [PATCH] D124789: [libc++] Find a clang-format everybody is happy with

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/.clang-format:68
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: Inner
+PackConstructorInitializers: NextLine
----------------
var-const wrote:
> What is the purpose of this setting? IIRC, LLVM never indents namespaces, which I think reduces unnecessary indentation and makes things easier to read.
+1 I actually found this independently. I also feel it works quite misleading in our codebase since `_LIBCPP_BEGIN_NAMESPACE_STD` doesn't seem to be counted as a namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124789/new/

https://reviews.llvm.org/D124789