[libcxx-commits] [PATCH] D128744: [libc++][ranges] Implement `ranges::partial_sort`.

Konstantin Varlamov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jul 2 19:08:41 PDT 2022


var-const added a subscriber: huixie90.
var-const added inline comments.


================
Comment at: libcxx/include/__algorithm/sift_down.h:53
 
-    value_type __top(_VSTD::move(*__start));
+    value_type __top(_BasicOperations<_Tag>::__iter_move(__start));
     do
----------------
@huixie90 This should call `ranges::iter_move` when the function is invoked from a range algorithm (and just `std::move(*__start))` when invoked from classic algorithms). Let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128744/new/

https://reviews.llvm.org/D128744



More information about the libcxx-commits mailing list