[libcxx-commits] [PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

[Petr Hosek via Phabricator via libcxx-commits]

phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:122
     set(RUNTIMES_${target}_LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "")
     set(RUNTIMES_${target}_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
     set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
----------------
Would it be possible to add `set(RUNTIMES_${target}_LIBCXX_CXX_ABI "libcxxabi-objects" CACHE STRING "")` here?


================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:189
     set(RUNTIMES_${target}_LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY OFF CACHE BOOL "")
     set(RUNTIMES_${target}_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
     set(RUNTIMES_${target}_LIBCXX_HERMETIC_STATIC_LIBRARY ON CACHE BOOL "")
----------------
Would it be possible to add `set(RUNTIMES_${target}_LIBCXX_CXX_ABI "libcxxabi-objects" CACHE STRING "")` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125683/new/

https://reviews.llvm.org/D125683