[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 31 17:04:32 PST 2022


philnik added a comment.

@Quuxplusone I would remove the python lint. clang-tidy is less flexible, but objectively better. It also detects `#include`-order problems in `#ifdef`s and knows what `#include_next` is. Putting that into a python script is not really feasible in my opinion, but prove me wrong if you want to. I also wouldn't leave them side by side, because that could potentially mean they contradict each other.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174



More information about the libcxx-commits mailing list