[libcxx-commits] [PATCH] D118634: [libc++][ranges] Add ranges::in_out_out_result

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo some nits.



================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp:14
+// template <class I1, class I2, class O>
+// struct in_in_out_result;
+
----------------
copy-paste.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp:78
+  {
+    std::ranges::in_out_out_result<int, double, float> res{10L, 0., 1.f};
+    assert(res.in == 10);
----------------
Why do you use `10L` when you want an `int`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118634/new/

https://reviews.llvm.org/D118634