[libcxx-commits] [PATCH] D118187: [libcxx] [Windows] Use the standard vsnprintf instead of _vsnprintf

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp:15
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// XFAIL: msvc
 // XFAIL: LIBCXX-AIX-FIXME
----------------
ldionne wrote:
> Quuxplusone wrote:
> > Is this XFAIL related to the "Microsoft C runtime specific quirks" you mention? It could use a comment to explain why we need to XFAIL here.
> Yeah, agreed, but otherwise LGTM.
Yes, it’s the same kind of quirks.

I have later follow-up patches to sort out exactly what these quirks are and try to make the test runnable in that mode, so I left out those details from this patch though.

But I can leave a fixme comment to make it clear that we’re not done here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118187/new/

https://reviews.llvm.org/D118187