[libcxx-commits] [PATCH] D117940: [libc++] [ranges] Implement std::ranges::distance

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 31 08:54:30 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM. We could/should look into simplifying some of the existing tests we have that use `stride_counting_iterator`. It occurs to me that those existing tests probably don't need to check `stride_counting_iterator<various archetypes>`, and a simple check like what you do here provides basically the same coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117940/new/

https://reviews.llvm.org/D117940



More information about the libcxx-commits mailing list