[libcxx-commits] [PATCH] D118616: [libc++] Use -I instead of -isystem to include headers in the test suite

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Using -isystem marks the headers as system headers, which means that we
don't actually get all the warnings that we'd normally get if we included
the headers as user headers.

The goal of the test suite is normally to mirror as closely as possible
how users would use the library. Technically, this change goes against
that philosophy, since users should be using `-isystem` (if they ever
need to specify the libc++ path explicitly, which should be a rare
occurence). However, I believe fishing out additional warnings from
the headers provides more value, hence this change. Ideally, we'd be
able to still use `-isystem`, but instruct Clang to still emit warnings
from the libc++ headers (e.g. we could tell Clang to emit warnings in
any file inside `<...>/usr/include/c++/v1`).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118616

Files:
  libcxx/test/configs/apple-libc++-shared.cfg.in
  libcxx/test/configs/ibm-libc++-shared.cfg.in
  libcxx/test/configs/llvm-libc++-mingw.cfg.in
  libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
  libcxx/test/configs/llvm-libc++-shared-gcc.cfg.in
  libcxx/test/configs/llvm-libc++-shared.cfg.in
  libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
  libcxx/test/configs/llvm-libc++-static.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118616.404544.patch
Type: text/x-patch
Size: 5604 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220131/96229de6/attachment-0001.bin>