[libcxx-commits] [PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

[Sam James via Phabricator via libcxx-commits]

thesamesam added a comment.

In D116857#3279111 <https://reviews.llvm.org/D116857#3279111>, @koakuma wrote:

> In D116857#3277968 <https://reviews.llvm.org/D116857#3277968>, @thesamesam wrote:
>
>> Thanks for doing the work on this and @kettenis for working on it originally too. I'd love to see this landed.
>>
>> I've tested this on sparc64 on Gentoo and it doesn't seem to build for me right now at commit bddc814b442ae9f30d62e2f881274d6255411225 <https://reviews.llvm.org/rGbddc814b442ae9f30d62e2f881274d6255411225>.
>
> Seems like this is because I forgot to add the `.register` directives before saving %g2, %g3, %g6, and %g7, and GCC doesn't like it.
> I've added the directives, can you please check if it builds there too? Thanks a lot!

Wow, thanks for the quick reply!

I think this is progress, only two errors:

  /var/tmp/portage/sys-libs/llvm-libunwind-14.0.0.9999/work/libunwind/src/UnwindCursor.hpp:1927:6:   required from here
  /var/tmp/portage/sys-libs/llvm-libunwind-14.0.0.9999/work/libunwind/src/DwarfParser.hpp:774:9: error: duplicate case value
    774 |         case REGISTERS_SPARC:
        |         ^~~~
  /var/tmp/portage/sys-libs/llvm-libunwind-14.0.0.9999/work/libunwind/src/DwarfParser.hpp:756:9: note: previously used here
    756 |         case REGISTERS_SPARC:
        |         ^~~~

I've attached the full log again: F21900314: build.log <https://reviews.llvm.org/F21900314>. Apparently I have both `_LIBUNWIND_TARGET_SPARC` and `_LIBUNWIND_TARGET_SPARC64` set?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857