[libcxx-commits] [PATCH] D118329: [libc++] Optimize algorithms on uninitialized memory for trivial types.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const added a comment.

In D118329#3277050 <https://reviews.llvm.org/D118329#3277050>, @Quuxplusone wrote:

> FWIW, libc++'s historical position on this kind of optimization (which I associate particularly with Marshall's tenure) is "libc++ should do the simple thing; file a codegen bug against //Clang// if it's failing to optimize our simple template code for some trivial type."  TBF, I have not looked closely at this PR to know whether that attitude would be unfair here for some reason.
> Do you have a Godbolt of the codegen before and after? (You should.)

@Quuxplusone This is a very good point. I'd suggest holding off the review for now until I have some data.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118329/new/

https://reviews.llvm.org/D118329