[libcxx-commits] [PATCH] D118502: [libcxx][test] Use = delete in libcxx/test/support/MoveOnly.h

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/support/MoveOnly.h:29-31
+    MoveOnly(const MoveOnly&) = delete;
+    MoveOnly& operator=(const MoveOnly&) = delete;
+
----------------
Just eliminate these; they're superfluous given lines 24–27.

But also, please re-upload the diff tagging it "libc++", because it doesn't look like the buildkite CI actually ran. It's just saying "Build 216170: arc lint + arc unit". https://reviews.llvm.org/harbormaster/build/216170/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118502/new/

https://reviews.llvm.org/D118502