[libcxx-commits] [PATCH] D118188: [libcxx] [Windows] Pick a unique bit for __regex_word

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D118188#3279833 <https://reviews.llvm.org/D118188#3279833>, @mstorsjo wrote:

> In D118188#3279825 <https://reviews.llvm.org/D118188#3279825>, @Quuxplusone wrote:
>
>> In D118188#3278624 <https://reviews.llvm.org/D118188#3278624>, @mstorsjo wrote:
>>
>>> Would it be ok to land this without the static assert, fixing the issue for one platform at least? Then when the AIX case gets fixed, we can add the static assert.
>>
>> FWIW, I'd prefer to land a static_assert now so we don't forget about it; but guard it under `#ifndef _AIX` or `XFAIL: LIBCXX-AIX-FIXME` or something like that (depending on where you put the assert), so that it's greppable for people working on AIX specifically.
>
> Oh, right, I could move the assert to a test - I placed it in the header so far, where it broke everything.

Even in the header, it could be guarded by `#ifndef _AIX`.  (That said, a test sounds good too. It'd just have to be in `libcxx/test/libcxx/`, right? because `__regex_word` is an implementation detail of libc++. Unless there's a way to regression-test the observable bug that was originally caused by this issue; that would be excellent too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118188/new/

https://reviews.llvm.org/D118188