[libcxx-commits] [PATCH] D118188: [libcxx] [Windows] Pick a unique bit for __regex_word

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 28 08:55:55 PST 2022


Quuxplusone added a comment.

In D118188#3278624 <https://reviews.llvm.org/D118188#3278624>, @mstorsjo wrote:

> Would it be ok to land this without the static assert, fixing the issue for one platform at least? Then when the AIX case gets fixed, we can add the static assert.

FWIW, I'd prefer to land a static_assert now so we don't forget about it; but guard it under `#ifndef _AIX` or `XFAIL: LIBCXX-AIX-FIXME` or something like that (depending on where you put the assert), so that it's greppable for people working on AIX specifically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118188/new/

https://reviews.llvm.org/D118188



More information about the libcxx-commits mailing list