[libcxx-commits] [PATCH] D118278: [libc++] Add documentation about the libc++ review group

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo one small issue.



================
Comment at: libcxx/docs/Contributing.rst:54
+you can commit it. However, if you get an approval very quickly for a significant patch,
+please try to wait a couple of business days before submitting to give the opportunity for
+other reviewers to chime in. If you need someone else to commit the patch for you, please
----------------



================
Comment at: libcxx/docs/Contributing.rst:60-62
+rule -- for very simple patches, use your judgement. The "libc++" review group consists
+of frequent libc++ contributors with a good understanding of the project's guidelines --
+if you would like to be added to it, please reach out on Discord.
----------------
Quuxplusone wrote:
> It would be good to find a way to indicate who belongs to this group; otherwise
> (1, the reactionary complaint) someone who considers themself a "frequent contributor with good understanding" may assume they are permitted to accept-as-libc++, when we don't want them to
> (2, the more constructive complaint) someone who's definitely a libc++-accepter, such as myself, may see that a PR has been greenlit by another contributor, but I'm not sure whether that other contributor counts as a libc++-accepter, so I'm not sure whether I should accept-as-libc++ or not.
> 
> Maybe we don't want to put the names right here, either because it'll bit-rot (but maybe we should maintain the list!) or because we're too modest (but we shouldn't be!). But it'd sure be nice to do //something// explicit.
> It would be good to find a way to indicate who belongs to this group; otherwise
+1 but not blocking for this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118278/new/

https://reviews.llvm.org/D118278