[libcxx-commits] [PATCH] D117660: [libc++] Fix a typo in reverse_iterator::operator=

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I read what you wrote, but adding a test should be really simple, right? Something like this:

  struct RefQualifiedIterator {
    template <typename T>
    RefQualifiedIterator(T const&);
  
    template <typename T>
    RefQualifiedIterator& operator=(T&) &;
  
    // other iterator members
  };

LGTM with or without the test, but I'd add it since it's so simple and it would have caught this bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117660/new/

https://reviews.llvm.org/D117660