[libcxx-commits] [PATCH] D118213: [libc++] [ranges] ADL-proof ranges::iter_{swap, move}.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 26 21:02:37 PST 2022


Quuxplusone updated this revision to Diff 403489.
Quuxplusone added a comment.

Restore a `(void)` I'd removed; turns out it is needed in order to suppress a user-provided `iter_swap`'s `[[nodiscard]]` attribute. (Fun.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118213/new/

https://reviews.llvm.org/D118213

Files:
  libcxx/include/__iterator/iter_move.h
  libcxx/include/__iterator/iter_swap.h
  libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.move/iter_move.pass.cpp
  libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.swap/iter_swap.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/bidirectional_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/common_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/contiguous_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/forward_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/input_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/output_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/random_access_range.compile.pass.cpp
  libcxx/test/std/ranges/range.req/range.refinements/viewable_range.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118213.403489.patch
Type: text/x-patch
Size: 26279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220127/f2dafe1c/attachment-0001.bin>


More information about the libcxx-commits mailing list