[libcxx-commits] [PATCH] D117537: [cmake] Partially deduplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added a comment.

@phosek

> I'd update this change to move `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` to `cmake/Modules/CheckLinkerFlag.cmake`

Note we cannot make that move because this is referred to from installed cmake modules, whereas `cmake/` is internal only and never installed.

I am a bit inclined to agree with @sebastian-ne. I don't like a bug I made staying open, and I rather get this done which at least moves us in the right direction and doesn't add any *new* sources of duplication.

We can still do the things you want to improve the situation (leaving compiler-rt) after.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537