[libcxx-commits] [PATCH] D118235: [libcxx] [test] Clarify a MinGW test failure waiver in rand.dist.uni.int/eval.pass.cpp

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 26 13:11:50 PST 2022


Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM if CI is green!
I observe that unfortunately we set `TEST_BUGGY_FOO` to `true` exactly when we //don't// want to test the buggy foo; but I think my original logic there was that `TEST_` was a prefix for all test macros, and so the name of the macro was meant to signify "(We're in a) test, and foo is buggy." Anyway, as long as this is consistent with `TEST_BUGGY_SIGNALING_NAN`, I'm cool with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118235/new/

https://reviews.llvm.org/D118235



More information about the libcxx-commits mailing list