[libcxx-commits] [PATCH] D118235: [libcxx] [test] Clarify a MinGW test failure waiver in rand.dist.uni.int/eval.pass.cpp

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 26 12:41:52 PST 2022


mstorsjo added inline comments.


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp:135
 
 #ifndef _LIBCPP_HAS_NO_INT128
     test_statistics<__int128_t, std::minstd_rand0>();
----------------
Quuxplusone wrote:
> Is there an easy way to just change this ifdef, assuming it controls the trouble spot in Clang 13?
> `git grep TEST_BUGGY_SIGNALING_NAN libcxx/test/` to see the approach I'm thinking of.
Oh, indeed, that works (I never checked that far in the source before) and is even nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118235/new/

https://reviews.llvm.org/D118235



More information about the libcxx-commits mailing list