[libcxx-commits] [PATCH] D118278: [libc++] Add documentation about the libc++ review group

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This explains stuff that most contributors already know, but it's always
good to write down explicitly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118278

Files:
  libcxx/docs/Contributing.rst


Index: libcxx/docs/Contributing.rst
===================================================================
--- libcxx/docs/Contributing.rst
+++ libcxx/docs/Contributing.rst
@@ -45,6 +45,22 @@
 - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
 - Did you run the ``libcxx-generate-files`` target and verify its output?
 
+The review process
+==================
+
+After uploading your patch, you should see that the "libc++" review group is automatically
+added as a reviewer for your patch. Once the group is marked as having approved your patch,
+you can commit it. However, if you get an approval very quickly for a significant patch,
+please try to wait a couple of business days before submitting to give the opportunity for
+other reviewers to chime in. If you need someone else to commit the patch for you, please
+mention it and provide your ``Name <email at domain>`` for us to attribute the commit properly.
+
+Note that the rule for accepting as the "libc++" review group is to wait for two members
+of the group to have approved the patch, excluding the patch author. This is not a hard
+rule -- for very simple patches, use your judgement. The "libc++" review group consists
+of frequent libc++ contributors with a good understanding of the project's guidelines --
+if you would like to be added to it, please reach out on Discord.
+
 Post-release check list
 =======================
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118278.403373.patch
Type: text/x-patch
Size: 1490 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220126/fa5f0608/attachment-0001.bin>