[libcxx-commits] [PATCH] D118056: [libc++][nfc] Include test_macros.h in more tests.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp:26
 #include "MoveOnly.h"
+#include "test_macros.h"
 
----------------
ldionne wrote:
> I don't understand why this is needed in several of the places where you're including the file. For example, here, I don't see anything that uses a macro in `test_macros.h`. Am I missing it?
As discussed on Discord, there was some confusion about the policy whether or not to always include this header. The header should only be included when needed. So the unneeded occurrences have been removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118056/new/

https://reviews.llvm.org/D118056