[libcxx-commits] [PATCH] D118254: [libc++][NFC] Move some functions from directory_iterator.cpp to filesystem_common.h

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D118254#3272672 <https://reviews.llvm.org/D118254#3272672>, @Quuxplusone wrote:

> Did you try moving `remove_all` into `directory_iterator.cpp`, and did that not work for some reason?
> (If you're just worried about naming, you could `s/iterator/iteration/`. ;))

No, I did not, because I like the fact that `directory_iterator` is implemented in `directory_iterator.cpp`, and that `remove_all` is defined in `operations.cpp`, which all makes sense to me. TBH I think the only reason why these functions were not defined in `filesystem_common.h` were to avoid including `<windows.h>` in a header, but since that's a private header, I think that's fine. IMO it could have been there from the start, along with all the other helpers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118254/new/

https://reviews.llvm.org/D118254