[libcxx-commits] [PATCH] D117537: [cmake] Partially deduplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D117537#3270331 <https://reviews.llvm.org/D117537#3270331>, @Ericson2314 wrote:

> @phosek does that reasoning check out to you?

I'd still like to avoid having multiple similar copies of this function in the tree.

I'd prefer starting with a smaller change that only modified `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` to use `CMAKE_REQUIRED_FLAGS` (it can also include the other changes you've made in this patch).

We can land that and if everything is working fine, I'd update this change to move `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` to `cmake/Modules/CheckLinkerFlag.cmake` and use it from everywhere except for compiler-rt which is going to need a more major cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537