[libcxx-commits] [PATCH] D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 25 17:40:55 PST 2022


CaseyCarter added a comment.

In D118194#3270797 <https://reviews.llvm.org/D118194#3270797>, @mstorsjo wrote:

> This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for `stdlib=msvc` - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)

Yes, we run a subset - although I'm trying to get folks motivated to grow that subset. We have an external control mechanism with a list of a few hundred XFAILs and a couple of dozen SKIPPEDs (which are effectively UNSUPPORTED except that we track them differently.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118194/new/

https://reviews.llvm.org/D118194



More information about the libcxx-commits mailing list