[libcxx-commits] [PATCH] D118134: [libc++] Fix TOCTOU issue with std::filesystem::remove_all

[Oliver Hunt via Phabricator via libcxx-commits]

ojhunt added inline comments.


================
Comment at: libcxx/src/filesystem/filesystem_common.h:572
+    if (errno)
+      ec = capture_errno();
+    return {};
----------------
(non-libc++ expert) Sorry if this is a dumb question: is capture_errno() API? is it safe to have in a header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118134/new/

https://reviews.llvm.org/D118134