[libcxx-commits] [PATCH] D118134: [libc++] Fix TOCTOU issue with std::filesystem::remove_all

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 25 15:26:58 PST 2022


ldionne updated this revision to Diff 403052.
ldionne marked 4 inline comments as done.
ldionne added a comment.

Completely new approach using parent file descriptors. I'm aware this patch as-is won't compile on Windows -- I'll fix that once I'm confident the base patch is alright. Windows is not affected by this issue anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118134/new/

https://reviews.llvm.org/D118134

Files:
  libcxx/src/filesystem/directory_iterator.cpp
  libcxx/src/filesystem/filesystem_common.h
  libcxx/src/filesystem/operations.cpp
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.remove_all/toctou.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118134.403052.patch
Type: text/x-patch
Size: 10627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220125/31c49ab8/attachment-0001.bin>


More information about the libcxx-commits mailing list