[libcxx-commits] [PATCH] D118069: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 24 13:02:18 PST 2022


CaseyCarter created this revision.
CaseyCarter added a reviewer: libc++.
CaseyCarter added a project: libc++.
CaseyCarter requested review of this revision.
Herald added 1 blocking reviewer(s): libc++.

... to be consistent with other `get_allocator` tests, and to avoid requiring `vector<T, allocator<U>>` to be valid.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118069

Files:
  libcxx/test/std/containers/sequences/vector.bool/get_allocator.pass.cpp


Index: libcxx/test/std/containers/sequences/vector.bool/get_allocator.pass.cpp
===================================================================
--- libcxx/test/std/containers/sequences/vector.bool/get_allocator.pass.cpp
+++ libcxx/test/std/containers/sequences/vector.bool/get_allocator.pass.cpp
@@ -20,13 +20,13 @@
 
 int main(int, char**) {
     {
-        std::allocator<int> alloc;
+        std::allocator<bool> alloc;
         const std::vector<bool> vb(alloc);
         assert(vb.get_allocator() == alloc);
     }
     {
-        other_allocator<int> alloc(1);
-        const std::vector<bool, other_allocator<int> > vb(alloc);
+        other_allocator<bool> alloc(1);
+        const std::vector<bool, other_allocator<bool> > vb(alloc);
         assert(vb.get_allocator() == alloc);
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118069.402635.patch
Type: text/x-patch
Size: 801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220124/a3d333d6/attachment.bin>


More information about the libcxx-commits mailing list