[libcxx-commits] [PATCH] D117537: [cmake] Partially deduplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added a comment.

In D117537#3266889 <https://reviews.llvm.org/D117537#3266889>, @phosek wrote:

> What's the reason for keeping both functions instead of changing `llvm_check_linker_flag` to use `CMAKE_REQUIRED_FLAGS`?



1. Abundance of caution / taking baby steos. No on had yet complained about how LLVM/Clang work yet pre the name collision.

2. I was planning on not trying to hack in compiler-rt using `llvm/cmake/modules` until `HandleOutOfTreeLLVM` there was fixed to handle that for us more cleanly. Conversely, compiler-rt can already use `cmake/Modules` just fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537