[libcxx-commits] [PATCH] D116974: [libc++] Add ranges::in_fun_result

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/algorithm:26
+  template <class I, class F>
+    struct in_fun_result; // since C++20
 }
----------------
`in_out_result` isn't listed here; and `in_in_out_result` either isn't listed, or merge-conflicts.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_fun_result.pass.cpp:31
+struct A {
+  explicit A(int);
+};
----------------
Same as on the `in_in_out` review, I think `A` would benefit from a comment about `// no implicit conversion`, and `B` could just be `B(int);`
In fact, all my comments from over there also apply here. Please add the exhaustive sets of `MoveOnly` tests, and so on and so forth. When you're done, `diff <(sed s/in_fun/foo/g in_fun_result.pass.cpp) <(sed s/in_in/foo/g in_in_result.pass.cpp)` should be basically an empty diff, and `~~~ <(sed s/in_in_out/foo/g in_in_out_result.pass.cpp)` not much different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116974/new/

https://reviews.llvm.org/D116974