[libcxx-commits] [PATCH] D117371: [libcxx][test] {move, reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter added a comment.

> Oh thanks for pointing this out and sorry for the noise.

Technically the description is incorrect for `move_iterator`, whose `reference` is `iter_rvalue_reference_t<Iter>` which also examines `decltype(*declval<Iter>())` indirectly (pun intended) via `ranges::iter_move`. It is a convenient approximation.

And don't sweat it: I'm renowned for ignoring commit messages, or at least forgetting them at some point during a review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117371/new/

https://reviews.llvm.org/D117371