[libcxx-commits] [PATCH] D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter created this revision.
CaseyCarter added a reviewer: libc++.
CaseyCarter added a project: libc++.
CaseyCarter requested review of this revision.
Herald added 1 blocking reviewer(s): libc++.

- Default-initialized `basic_string` iterators are not portably in the domain of `==`.
- Avoid comparing iterators from non-equal string_views which MSVCSTL considers not to be in the domain of equality.
- Don't test invalid range `[in, out + N)`.

Also silence some truncation warnings by testing with a non-narrowing conversion.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118049

Files:
  libcxx/test/std/ranges/range.adaptors/range.all/range.owning.view/begin_end.pass.cpp
  libcxx/test/std/ranges/range.adaptors/range.transform/iterator/plus_minus.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/iterators.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.copy/ranges_uninitialized_copy.pass.cpp
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.copy/ranges_uninitialized_copy_n.pass.cpp
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.move/ranges_uninitialized_move.pass.cpp
  libcxx/test/std/utilities/memory/specialized.algorithms/uninitialized.move/ranges_uninitialized_move_n.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118049.402551.patch
Type: text/x-patch
Size: 7713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220124/eb8dcf1f/attachment.bin>