[libcxx-commits] [PATCH] D118029: Introduce branchless sorting functions for sort3, sort4 and sort5.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

A few points right now:
(1) Please use `using x = `. It's a clang extension in C++03, so we can use it.
(2) `__magic_swap` is a really bad name. Please change that to something more meaningful.
(3) Don't qualify any type traits with `_VSTD::`.
(4) You can't use `enable_if_t`. Use `__enable_if_t` instead.
I'll have a closer look later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118029/new/

https://reviews.llvm.org/D118029