[libcxx-commits] [PATCH] D117512: [libc++][ranges] Add ranges::in_in_out_result

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 24 03:44:00 PST 2022


philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp:79
+    assert(res.out == 1.f);
+    std::ranges::in_in_out_result<ConstructibleFrom<int>, ConstructibleFrom<double>, ConstructibleFrom<float>> res2 = res;
+    assert(res2.in1.content == 10);
----------------
Quuxplusone wrote:
> I don't think this buys you anything over a simple
> ```
> std::ranges::in_in_out_result<long, float, int> res2 = res;
> assert(res2.in1 == 10L);
> ~~~
> ```
> (Also, moot point now, but `ConstructibleFrom` would be the wrong name for something that's implicitly //convertible// from; `ConvertibleFrom` would have been a better name.)
It's the same as in D116278.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117512/new/

https://reviews.llvm.org/D117512



More information about the libcxx-commits mailing list