[libcxx-commits] [PATCH] D117953: [libc++] Fix LWG3146 "Excessive unwrapping in std::ref/cref"

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a comment.

LGTM % nits



================
Comment at: libcxx/include/__functional/reference_wrapper.h:179
 
 #if _LIBCPP_STD_VER >= 17
 template <class _Tp>
----------------
Pre-existing


================
Comment at: libcxx/test/std/utilities/function.objects/refwrap/refwrap.helpers/cref_2.pass.cpp:39
+  }
+  {
+    int i = 0;
----------------
I think I'd rather see `// LWG 3146` here. Both tests are for the LWG issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117953/new/

https://reviews.llvm.org/D117953