[libcxx-commits] [PATCH] D117966: [libcxx][test] tests for strengthened `noexcept` are non-portable

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added subscribers: zoecarver, ldionne, Quuxplusone.
Quuxplusone added reviewers: ldionne, zoecarver.
Quuxplusone added a comment.

I actually don't see any textual support for our metaprogrammy conditional-noexcepts in `view_interface` at all. @zoecarver if you're still around, what was the rationale for all the conditional-noexcept in D101737 <https://reviews.llvm.org/D101737>? Would anything important break if we just got rid of it all?

Not only would removing the noexcept-specifications be simpler, safer <https://quuxplusone.github.io/blog/2018/06/12/attribute-noexcept-verify/#update-david-stone-points-out-th>, and faster-to-compile, but it would also jibe with @ldionne's general philosophy of keeping as close to the Standard as possible. The Standard doesn't say that these functions should ever be noexcept, so by making ours sometimes-noexcept, we might be opening up portability pitfalls for libc++'s users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117966/new/

https://reviews.llvm.org/D117966