[libcxx-commits] [PATCH] D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, please fix the line-size comment before committing.



================
Comment at: libcxx/test/std/ranges/range.utility/view.interface/view.interface.pass.cpp:82-84
+struct MultipleInheritanceViewInterface : std::ranges::view_interface<InputRange>, std::ranges::view_interface<MoveOnlyForwardRange> {
+};
+static_assert(!std::ranges::view<MultipleInheritanceViewInterface>);
----------------
Quuxplusone wrote:
> Please do something to fix the long line. I suggest `s/MultipleInheritanceViewInterface/MI/g`.
> (Also, wasn't this supposed to be landed as part of D117918? Too late now, anyway.)
> 
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117714/new/

https://reviews.llvm.org/D117714