[libcxx-commits] [PATCH] D117811: [libc++] Remove _VSTD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D117811#3262965 <https://reviews.llvm.org/D117811#3262965>, @wmaxey wrote:

> As @__simt__ has stated, we do make use of this macro, but are open to the idea of an alternative that does provide similar configurability.
>
> This macro is used to differentiate between two namespaces depending on how the project is included/used. It would be possible for us to move away from some such a mechanism, but ideally rather than deleting it, I would like to see it be replaced with something that allows us to assume the namespace we need to search isn't necessarily `std::`

We know that people change it, but we don't know //how// it is used. Could you provide a specific example that uses `_VSTD`? If we don't know how `_VSTD` is used we can't determine how to officially support these use cases or see if it is necessary for these use-cases to even have `_VSTD`. Would it be possible to just change `_LIBCPP_BEGIN_NAMESPACE_STD`? I don't think we'll remove that. It would probably also be possible to make that configurable by the user more easily.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117811/new/

https://reviews.llvm.org/D117811