[libcxx-commits] [PATCH] D117393: [libc++] Use addressof in unordered_map.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D117393#3258668 <https://reviews.llvm.org/D117393#3258668>, @philnik wrote:

> Shouldn't there also be a test for `insert_or_assign` then?

They didn't fail for me, so I haven't been able get test failure with them. So I prefer the whack-a-mole approach for this. Writing tests for all possible cases seems a lot of work with little benefit. But feel free to add additional tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117393/new/

https://reviews.llvm.org/D117393