[libcxx-commits] [PATCH] D117811: [libc++] Remove _VSTD

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

@philnik, I suggest opening a discussion thread on the Discord if you still want to pursue this direction at all.
D117811 <https://reviews.llvm.org/D117811> duplicates D55517 <https://reviews.llvm.org/D55517> (December 2018), which was abandoned, and I don't think we have any "new information" since then.
`_VSTD` and `std` currently are not synonymous — there are places you can grep for where we deliberately use `std::` not `_VSTD::` — and this seems like it would erase that deliberate difference. Whether the deliberate difference is //useful//, I don't know. But at the very least, you could propose a preliminary PR that removes just the difference (i.e. change just those few existing places to use `_VSTD::` instead of `std::`), and let someone explain why even //that// would be a bad idea. It could be a learning experience for all of us. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117811/new/

https://reviews.llvm.org/D117811