[libcxx-commits] [PATCH] D117811: [libc++] Remove _VSTD

[Roman Lebedev via Phabricator via libcxx-commits]

lebedev.ri added subscribers: __simt__, lebedev.ri.
lebedev.ri added a comment.

How can there be no practical difference if one is a configurable 'macro' and other isn't?

In D55517#1326179 <https://reviews.llvm.org/D55517#1326179>, @__simt__ wrote:

> Hello Eric, everyone else,
>
> We have projects that are getting great mileage from this macro right now, we'd be sad to see it go. 😰
>
> If you look at https://github.com/ogiroux/freestanding you'll get the gist of what we're doing with it: //we don't just change the inline namespace name, we also change the// `std::` //namespace name using the macro//. This was never the intended use, I realize, but it allows us to make progress with e.g. side-by-side co-existence for a large & important subset. In other words, the presence of this macro helped make libc++ adaptable the way needed it to be, and may slowly transform us into contributors even (hence netting you great mileage too).
>
> So our view is that we would not like to see this change made. Sorry.
>
> Olivier




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117811/new/

https://reviews.llvm.org/D117811