[libcxx-commits] [PATCH] D117714: [libc++] Implement LWG3549: view_interface need not inherit from view_base

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 20 12:30:40 PST 2022


jloser updated this revision to Diff 401744.
jloser marked an inline comment as done.
jloser added a comment.

Add ADL-proofing test
Add private inheritance test showing the `static_cast` approach hard errors. Rework implementatin to be clever and rely on lambdas in unevaluated contexts. If this doesn't work yet on CI, we can delegate to a helper functin template.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117714/new/

https://reviews.llvm.org/D117714

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/include/__ranges/enable_view.h
  libcxx/include/__ranges/view_interface.h
  libcxx/test/std/ranges/range.req/range.view/enable_view.compile.pass.cpp
  libcxx/test/std/ranges/range.utility/view.interface/view.interface.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117714.401744.patch
Type: text/x-patch
Size: 5613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220120/865ab928/attachment-0001.bin>


More information about the libcxx-commits mailing list