[libcxx-commits] [PATCH] D117537: [cmake] Duplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 marked an inline comment as done.
Ericson2314 added a comment.

@phosek I agree with your fixing what language to do each flag, but do note I was purposely matching the existing dubious categorizations. Might it be better to first land this as-is, and then make a separate patch to clean up the languages?



================
Comment at: compiler-rt/CMakeLists.txt:24-25
+
+  # Find the LLVM sources and simulate LLVM CMake options.
+  include(HandleOutOfTreeLLVM)
+endif()
----------------
phosek wrote:
> Ericson2314 wrote:
> > @phosek here is compiler-rt using it, as you wanted.
> Thanks, can we land this separately?
Done in D117815


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537