[libcxx-commits] [PATCH] D117811: [libc++] Remove _VSTD

Thu Jan 20 11:24:38 PST 2022

philnik added a comment.

In D117811#3259144 <https://reviews.llvm.org/D117811#3259144>, @dim wrote:

> How do you mean "no practical difference"? `_VSTD` is defined as `std::_LIBCPP_ABI_NAMESPACE`, and in turn, `_LIBCPP_ABI_NAMESPACE` is configurable by the user, or defaults to mangling the ABI version in it. So this would be a huge change, for unknown benefit?

This patch isn't changing in which namespace the symbols are. Everything is still in `std::_LIBCPP_ABI_NAMESPACE`. `_VSTD` is only used when accessing anything in `std::_LIBCPP_ABI_NAMESPACE` and since `_LIBCPP_ABI_NAMESPACE` is always an inline namespace all the symbols are also accessible in `std`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117811/new/

https://reviews.llvm.org/D117811