[libcxx-commits] [PATCH] D116891: [libc++][CI] Re-enable all CI jobs

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 20 08:50:39 PST 2022


philnik added a comment.

In D116891#3258420 <https://reviews.llvm.org/D116891#3258420>, @ldionne wrote:

> In D116891#3256717 <https://reviews.llvm.org/D116891#3256717>, @philnik wrote:
>
>> Is there a reason this isn't landed yet? AFAIK the build nodes are back online.
>
> I love how fast the current reduced CI is, and I wanted to think about ways we can retain the same coverage and the same CI turnaround times.
>
> I'll check this in now and I can do that later. Basically, I think what I want is a slightly reduced matrix when reviews are uploaded, but the full matrix being run once every 4 hours (we already have a build that does that). Philosophically, what I'd prefer is the full matrix every time, but the hardware constraints we have are real, not philosophical, and the benefits of having quicker CI turnaround time are too.

Couldn't we just add more pipeline steps? Most of the builds only fail in groups and only testing one of them would mean less resource usage. This would of course mean that the build could take longer if all the builds are green.
I'd suggest something like
Format, Generated output, Documentation -> C++2b, C++20, C++03, Modular build -> Windows, MacOS, Arm, AIX, No *, Debug iterators, Assertions, C++17, C++14, C++11 -> All the very resource intensive tests
I probably forgot a few configs, but that should cover most of them. This would lead to less unnecessary resource usage while still having full test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116891/new/

https://reviews.llvm.org/D116891



More information about the libcxx-commits mailing list