[libcxx-commits] [PATCH] D117585: [libcxx] Support waiting on steady clock with ext. threading

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

No comment from me; this is above my pay grade. :)
But I could bikeshed the name of the macro: The old name reflected the pthreads name, `pthread_cond_clockwait` -> `_LIBCPP_HAS_COND_CLOCKWAIT`. The new name reflects nothing we didn't make up ourselves; so maybe it should be more like `_LIBCPP_HAS_MONOTONIC_TIMEDWAIT` or `_LIBCPP_CONDVAR_HAS_MONOTONIC_TIMEDWAIT`. My understanding is that "steady" is a WG21-ism for "monotonic": even though you named the new function `__libcpp_condvar_steady_timedwait`, we never actually use `steady_clock` anywhere in its signature or implementation. Instead it depends on pthreads' `CLOCK_MONOTONIC`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117585/new/

https://reviews.llvm.org/D117585